-
Notifications
You must be signed in to change notification settings - Fork 364
slice scatter support for dynamic cases #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peri044
reviewed
May 16, 2025
3d9171d
to
51b64bc
Compare
51b64bc
to
1b8fd58
Compare
peri044
reviewed
Jun 13, 2025
Rest of the code LGTM |
apbose
added a commit
that referenced
this pull request
Jul 7, 2025
apbose
added a commit
that referenced
this pull request
Jul 18, 2025
apbose
added a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
component: api [Python]
Issues re: Python API
component: dynamo
Issues relating to the `torch.compile` or `torch._dynamo.export` paths
component: lowering
Issues re: The lowering / preprocessing passes
component: tests
Issues re: Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with reference to #3448.
The error currently being faced is that- (div_2, sym_size_int_3669, mul_102, mul_114, reshape_default_3, mul_213, div_113, mul_2962, clone_54, select_1, clone_67, expand_122, slice_16, clone_68, expand_123, mul_4869, expand_184,
expand_185, mul_7245, expand_246, expand_247, mul_9621, expand_308, expand_309, mul_11997, expand_370, expand_371, mul_14373, expand_432, expand_433, mul_16749, expand_494, expand_495, expand_556, expand_557,
mul_21501, expand_618, expand_619, mul_23877, expand_680, expand_681, mul_26253, expand_742, expand_743, mul_28629, expand_804, expand_805, mul_31005, expand_866, expand_867, mul_33381, expand_928, expand_929,
mul_35757, expand_990, expand_991, mul_38133, expand_1052, expand_1053, mul_40509, expand_1114, expand_1115, mul_42885, expand_1176, expand_1177, mul_45261, expand_1238, expand_1239, mul_47637, expand_1300, exp
and_1301, mul_50013, expand_1362, expand_1363, mul_52389, expand_1424, expand_1425, mul_54765, expand_1486, expand_1487, mul_57141, expand_1548, expand_1549, mul_59517, expand_1610, expand_1611)
There are symints in the output, whose dtype are not appended here
but it is present in the engine output. So there are missing output dtypes.
Update: the above is corrected by #3488